Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: catch std::stoi exception and improve error msg #36296

Merged
merged 1 commit into from
Sep 18, 2024
Merged

enhance: catch std::stoi exception and improve error msg #36296

merged 1 commit into from
Sep 18, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #36255
pr: #36267

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 14, 2024
@jaime0815 jaime0815 force-pushed the catch-stoi-exception-24 branch from 6d99731 to 1e0814a Compare September 14, 2024 09:56
@codecov Codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.17647% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (1cd8d1b) to head (32e4cba).
Report is 21 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/core/src/index/Utils.cpp 28.57% 10 Missing ⚠️
internal/core/src/storage/DiskFileManagerImpl.cpp 50.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36296      +/-   ##
==========================================
- Coverage   81.15%   81.09%   -0.07%     
==========================================
  Files        1059     1060       +1     
  Lines      139498   139625     +127     
==========================================
+ Hits       113214   113231      +17     
- Misses      22007    22101      +94     
- Partials     4277     4293      +16
Files with missing lines Coverage Δ
internal/core/src/index/Utils.cpp 36.51% <28.57%> (-1.44%) ⬇️
internal/core/src/storage/DiskFileManagerImpl.cpp 66.26% <50.00%> (-1.09%) ⬇️

... and 53 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815 jaime0815 force-pushed the catch-stoi-exception-24 branch from 1e0814a to 32e4cba Compare September 18, 2024 04:01
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 18, 2024
@mergify mergify bot added the ci-passed label Sep 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Sep 18, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 817fe48 into milvus-io:2.4 Sep 18, 2024
14 of 15 checks passed
@jaime0815 jaime0815 deleted the catch-stoi-exception-24 branch September 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime0815 @czs007 @sre-ci-robot